kreait / laravel-firebase

A Laravel package for the Firebase PHP Admin SDK
https://github.com/kreait/firebase-php
MIT License
992 stars 163 forks source link

Set default timeout for http client #146

Closed ankurk91 closed 1 year ago

ankurk91 commented 1 year ago

Hi,

It is recommended to have a sensible default HTTP timeout.

Laravel itself has set a default timeout to their HTTP client.

It should not be a breaking change for existing users.

jeromegamez commented 1 year ago

Thanks for your contribution! This would be better suited to the SDK itself (https://github.com/kreait/firebase-php/blob/6.x/src/Firebase/Http/HttpClientOptions.php#L16), could you please create the PR there?

ankurk91 commented 1 year ago

@jeromegamez sure, i will

ankurk91 commented 1 year ago

@jeromegamez When https://github.com/kreait/firebase-php/pull/723 is merged , we still need to update the doc block in config file saying "indefinitely"

jeromegamez commented 1 year ago

Yes, I'll do that once I released the SDK and have updated the Laravel Package with the bumped dependency, thank you! 🙏