kreait / laravel-firebase

A Laravel package for the Firebase PHP Admin SDK
https://github.com/kreait/firebase-php
MIT License
992 stars 163 forks source link

add support for Laravel v10 #163

Closed ankurk91 closed 1 year ago

ankurk91 commented 1 year ago

Description

Laravel 10 will be released on 7th Feb 2023

I could not make the Github actions to pull Laravel 10 :( May be we should add another matrix for Laravel version.

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #163 (a74656c) into main (480867b) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #163   +/-   ##
=========================================
  Coverage     98.30%   98.30%           
  Complexity       44       44           
=========================================
  Files             3        3           
  Lines           118      118           
=========================================
  Hits            116      116           
  Misses            2        2           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mtawil commented 1 year ago

Hello @jeromegamez, please have a look at this PR.

Laravel 10 is released and we need to upgrade

asugai commented 1 year ago

I'm in the same boat - hoping this can be updated quickly

jeromegamez commented 1 year ago

I already had a look, I will get to it soon, it's probably a little more than just updating the version constraints in the composer.json file. I'm sure you'll stay tuned πŸ˜„

ankurk91 commented 1 year ago

All tests are passing on my local machine with orchestra/testbench v8.0 for this package.

jeromegamez commented 1 year ago

Oh, I was wrong, it is as simple as updating the version constraints - I forgot that I changed the Workflows to not use testbench anymore Γ€, so it is as easy as updating the version constraints πŸ™ˆ.

jeromegamez commented 1 year ago

Thanks @ankurk91!

jeromegamez commented 1 year ago

Dangit, I was wrong again (https://github.com/kreait/laravel-firebase/actions/runs/4181145066), I should have looked at it on my computer instead of the phone πŸ˜‚. I'll get to it in the next few hours when I'm at my desk.

jeromegamez commented 1 year ago

Here it is: https://github.com/kreait/laravel-firebase/releases/tag/5.1.0

asugai commented 1 year ago

thank you @jeromegamez !