kreait / laravel-firebase

A Laravel package for the Firebase PHP Admin SDK

https://github.com/kreait/firebase-php

MIT License

992 stars 163 forks source link

fix: pin phpunit to v9 #167

Closed ankurk91 closed 1 year ago

ankurk91 commented 1 year ago

@jeromegamez

It looks like composer is picking php-unit v10 due to test-bench v8.x. We can stick to php unit v9 for now. This will fix the GitHub actions.

jeromegamez commented 1 year ago

That's not the full picture. I'm on it and will let you know when I'm finished 🤞🏻🙏🏻

codecov[bot] commented 1 year ago

Codecov Report

Merging #167 (e766b59) into main (785e55e) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #167   +/-   ##
=========================================
  Coverage     98.30%   98.30%           
  Complexity       44       44           
=========================================
  Files             3        3           
  Lines           118      118           
=========================================
  Hits            116      116           
  Misses            2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jeromegamez commented 1 year ago

Here's the release: https://github.com/kreait/laravel-firebase/releases/tag/5.1.0

The tests were throwing an additional deprecation message (PHPUnit 9 warned about features being deprecated in PHPUnit 10) and I wanted to make sure that both Laravel versions are tested.

Thanks again!