Codecov Report

Merging #60 into main will decrease coverage by 2.59%. The diff coverage is 66.66%.

@@              Coverage Diff              @@
##                main      #60      +/-   ##
=============================================
- Coverage     100.00%   97.40%   -2.60%     
- Complexity        19       21       +2     
=============================================
  Files              1        1              
  Lines             71       77       +6     
=============================================
+ Hits              71       75       +4     
- Misses             0        2       +2

Impacted Files	Coverage Δ	Complexity Δ
src/ServiceProvider.php	`97.40% <66.66%> (-2.60%)`	`21.00 <0.00> (+2.00)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae6d338...83d6f98. Read the comment docs.

jeromegamez commented 3 years ago

Hey @kakajansh 👋 and thanks for your contribution, it's a good one! Once you made the suggested change, we're ready to merge 🤞

jeromegamez commented 3 years ago

Sorry for the long delay - #67 came in between and since that changed how the package is configured, I wanted to merge that one before including your PR.

The specification of HTTP Client Options is merged with https://github.com/kreait/laravel-firebase/commit/75f9c825baafffeed7f0fdb9705d5b3ad1c3c9c1 - I changed the http_client key to http_client_options and added a test, but made sure that your name is preserved in the commit.

Thank you very much for your contribution, it's highly appreciated! 🌺

kreait / laravel-firebase

Adds HTTP client options #60

Codecov Report