search

kreait / laravel-firebase

A Laravel package for the Firebase PHP Admin SDK
https://github.com/kreait/firebase-php
MIT License
994 stars 163 forks source link

Notification channel #69

Closed dododedodonl closed 2 years ago

dododedodonl commented 3 years ago

Adds a notification channel that supports Tokens, Topics and Conditions.

codecov[bot] commented 3 years ago

Codecov Report

Merging #69 (82ec2e1) into main (68e5def) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #69   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        46        65   +19     
===========================================
  Files              3         5    +2     
  Lines            127       169   +42     
===========================================
+ Hits             127       169   +42
Impacted Files Coverage Δ Complexity Δ
src/Exception/MessagingChannelException.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Notifications/FirebaseMessagingChannel.php 100.00% <100.00%> (ø) 18.00 <18.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68e5def...687fd15. Read the comment docs.

ankurk91 commented 2 years ago

@jeromegamez

Any plans to merge this PR?

dododedodonl commented 2 years ago

Features provided by this PR are now also available in https://github.com/laravel-notification-channels/fcm which would be a better choice. Closing this PR.

ankurk91 commented 2 years ago

i have released this PR as package https://github.com/ankurk91/fcm-notification-channel