search

kreait / laravel-firebase

A Laravel package for the Firebase PHP Admin SDK
https://github.com/kreait/firebase-php
MIT License
994 stars 163 forks source link

Tenant Awareness #79

Closed sl0wik closed 3 years ago

sl0wik commented 3 years ago

authentication.tenant_id added to config.

Ref.: https://firebase-php.readthedocs.io/en/5.14.1/authentication.html#tenant-awareness

codecov[bot] commented 3 years ago

Codecov Report

Merging #79 (0344ae2) into main (4fa91e5) will decrease coverage by 0.77%. The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main      #79      +/-   ##
=============================================
- Coverage     100.00%   99.22%   -0.78%     
- Complexity        46       47       +1     
=============================================
  Files              3        3              
  Lines            127      129       +2     
=============================================
+ Hits             127      128       +1     
- Misses             0        1       +1
Impacted Files Coverage Ξ” Complexity Ξ”
src/FirebaseProjectManager.php 98.24% <50.00%> (-1.76%) 25.00 <0.00> (+1.00) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 4fa91e5...c6ad3a1. Read the comment docs.

jeromegamez commented 3 years ago

Nice and short, thank you very much! 🌺

Merged with c2f95693a1ef6ff2a2c87ac0ec1619cf061fcc22 and released as https://github.com/kreait/laravel-firebase/releases/tag/3.1.0 πŸš€

I renamed authentication to auth because the SDK also refers to it as the "Auth" component, updated FIREBASE_TENANT_ID to FIREBASE_AUTH_TENANT_ID (to keep the FIREBASE_<COMPONENT>_<NAME> scheme), and added a test, all in your name, I hope that's okay πŸ˜