search

kreativekorp / open-relay

Free and open source fonts from Kreative Software
170 stars 9 forks source link

very large margin for the first line #78

Open GamingKing2436 opened 9 months ago

GamingKing2436 commented 9 months ago

for fairfaxHD, it has a very large margin on the first line for some reason. this did not happen in a december version of the font. it also does not apply to the SMHD version. see example in this font viewing app: Screenshot_20240222_214500_FontViewer used as a font in other apps: Screenshot_20240221_085517_Settings not sure what causes this yet.

GamingKing2436 commented 8 months ago

okay SMHD does have a large margin for the first line, but it's only a small subtle increase, which means all the fonts were probably intended to have some small margin. the other fonts be having like 3x margin tho.

RebeccaRGB commented 8 months ago

Android is doing something very stupid here and using the font bounding box to determine the line height of the first and last line instead of the ascent, descent, and line gap metrics that it should be using.

There are some recent changes that attempt to fix this but I don't know when they'll be released / if they're already released / if they actually fix this problem / if they actually fix this problem in every case or just in some cases / etc.

I may have to provide an ugly hacked version just for Android. :/

GamingKing2436 commented 7 months ago

lol funny hack

i'm pretty sure that would be only in some cases, as apps can apperently choose their own includeFontPadding value (probably rare tho). it's been released, but stable 1.6.0 was only released on January 24, 2024, so it'll probably take a while anyways.