search

kreezxil / Lava-Dynamics

Adding Vulcanism to Minecraft via Block Update Detection (BUD)
3 stars 3 forks source link

Crash w/ World Creation, WildNature World Type #21

Closed WenXin20 closed 4 years ago

WenXin20 commented 5 years ago

Describe the bug

I got this crash after creating a new world using the WildNature World Type.

To Reproduce

  1. Create a New World
  2. Choose WildNature as the World Type
  3. Crash

Versions:

Logs (REQUIRED):

Storage Files (REQUIRED)

LD_Checkedstorage (One line in the file only): 0|12 The LD_Volcanostorage file was empty

eleksploded commented 5 years ago

Can you post your config file?

WenXin20 commented 5 years ago

I realized that I forgot to remove the ore entry mubble:vanadium_ore|0. I had removed the Mubble mod but forgot I had added it's ore to the config. Could that be what is causing the crash? Config

eleksploded commented 5 years ago

If that name doesn’t actually point to an actual block, then yes, that would cause the crash.

kreezxil commented 5 years ago

you should add code that quietly ignores bad entries the list but with a loggable output when it does.

Like in console it should say "ignoring invalid block entry because it doesn't exist modid:blockid"

On Sun, Aug 11, 2019 at 3:31 PM Eleksploded notifications@github.com wrote:

If that name doesn’t actually point to an actual block, then yes, that would cause the crash.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kreezxil/Lava-Dynamics/issues/21?email_source=notifications&email_token=AA5TJCCXS5VMHUFPN4DJDBDQEBZL3A5CNFSM4IK3CWA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BIEJQ#issuecomment-520258086, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5TJCEQD6G5U6J2W6HSJZLQEBZL3ANCNFSM4IK3CWAQ .

WenXin20 commented 5 years ago

I tried to create a WildNature world type again without the mubble:vanadium_ore|0 entry, but I still get a crash, although it looks to be a bit different. Crash Report

eleksploded commented 5 years ago

Kreezxil, That is actually implemented in 5.6.7, but I'm still fixing some stuff up before releasing. I'll look over the new crash and see what I can do.