search

kreezxil / Lava-Dynamics

Adding Vulcanism to Minecraft via Block Update Detection (BUD)
3 stars 3 forks source link

Use Forge's Config Annotation system #7

Closed TheGreatGeek25 closed 6 years ago

TheGreatGeek25 commented 6 years ago

Redo configs to use Forge's Config Annotation system. When the configs are defined this way, Forge automatically generates a GUI that can be used to edit config files ingame.

In either system, when options or categories are deleted/moved, the old version stays in the config file. The GUI generated by Forge includes these old versions, which could cause some confusion. To avoid this, I suggest keeping (but maybe ignoring) old options/categories for a few versions with a comment to tell the user that these will be deleted in a later version.

kreezxil commented 6 years ago

Thank you for your efforts. In the future when you decide that comments or commented code needs to be removed, please confer with me. This is an actively developed project and I store my notes and experiments within it. As you are aware, comments of any sort do not make it into the compiled binaries. So removing them simply removes the ability to understand the nature of something later on that the programmer is trying to convey to another programmer later in the timeline. Usually that programmer is simply talking to himself.

TheGreatGeek25 commented 6 years ago

Okay. Sorry about that. Should I open another pull request to add the deleted code back?

kreezxil commented 6 years ago

No, because it's github, I can easily fork at an earlier to time to retrieve it. I like your changes, just in the future for my projects keep that in mind.

On Sun, Jun 17, 2018 at 12:56 PM TheGreatGeek25 notifications@github.com wrote:

Okay. Sorry about that. Should I open another pull request to add the deleted code back?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kreezxil/Lava-Dynamics/pull/7#issuecomment-397895353, or mute the thread https://github.com/notifications/unsubscribe-auth/ADs0iKFBL1mWC9FJyq95Dg0dBqVtq4zrks5t9phXgaJpZM4Uqp5D .