search

kreezxil / World-of-Dragons-A-New-Age

Word of Dragons based on WyrmRoost
https://www.curseforge.com/minecraft/modpacks/world-of-dragons-a-new-age
0 stars 0 forks source link

Minecolonies armor incompatibility with Mine and Slash crafted armor #76

Closed Soutemumb closed 4 years ago

Soutemumb commented 4 years ago

Colony guard NPCs cannot wear crafted vanilla armor after it's converted to mine and slash armor with it's stats.

AzureDoom commented 4 years ago

This sounds like an issue for Minecolonies to fix.

kreezxil commented 4 years ago

@azuredoom maybe you can provide a method to autocompat such that if a vanilla crafted armor is crafted against a cactus or flint, the attributes are scraped off restoring it to pure vanilla.

On Fri, Nov 22, 2019 at 1:46 AM AzureDoom notifications@github.com wrote:

This sounds like an issue for Minecolonies to fix.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kreezxil/World-of-Dragons-A-New-Age/issues/76?email_source=notifications&email_token=AA5TJCE5JMI4ONSRVLSM3MTQU6E7DA5CNFSM4JQM7F2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE42Z7I#issuecomment-557427965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5TJCCZ6JPJYRY55QFTFOLQU6E7DANCNFSM4JQM7F2A .

marchermans commented 4 years ago

I work on minecolonies, and we basically just ask the armor for its level and type That is it. If the worker and hut are leveled up enough the armor is allowed for the guards to be worn. @kreezxil Do you guys do something special with your items to make them some kind of fake armor?

AzureDoom commented 4 years ago

The armor gain extra NBT via the mod Mine and Slash. This bit of NBT is causing the issue.

kreezxil commented 4 years ago

please check in todays update of the patch to see if this issue has been resolves

@Soutemumb @AzureZhen @OrionDevelopment @Tarlin83

Soutemumb commented 4 years ago

The bug hasn't been solved, the guard in my minecolony still refuses to wear the armor.

kreezxil commented 4 years ago

@AzureZhen minecolonies teams says they can't fix this problem. Can you patch autocompat to not change the values of vanilla armor?

AzureDoom commented 4 years ago

@kreezxil there is an config option just for this reason. Just go ahead and turn it to false. It will disable the Vanilla items getting stats.

kreezxil commented 4 years ago

ok, i didn't know that was there.