search

kreezxil / World-of-Dragons-A-New-Age

Word of Dragons based on WyrmRoost
https://www.curseforge.com/minecraft/modpacks/world-of-dragons-a-new-age
0 stars 0 forks source link

[please fix] Armors from Silent Gear not scaling with M&S #9

Closed T0uchMeSenpai closed 4 years ago

T0uchMeSenpai commented 5 years ago

The custom armors you can make from blueprints from the Silent Gear mod do not scale, though weapons do. Not sure if a bug or not, but since weapons scale, it's logical to conclude armors should too.

kreezxil commented 5 years ago

this is likely an issue between M&S and SG

On Tue, Oct 29, 2019 at 7:22 AM T0uchMeSenpai notifications@github.com wrote:

The custom armors you can make from blueprints from the Silent Gear https://www.curseforge.com/minecraft/mc-mods/silent-gear mod do not scale, though weapons do. Not sure if a bug or not, but since weapons scale, it's logical to conclude armors should too.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kreezxil/World-of-Dragons-A-New-Age/issues/9?email_source=notifications&email_token=AA5TJCBDVY6XSVOH2LGVLI3QRATJXA5CNFSM4JGHXDN2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HVBFWGA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5TJCD5PWMYOFYYUYOOWJLQRATJXANCNFSM4JGHXDNQ .

kreezxil commented 5 years ago

I haven't reported it yet. Today's patch doesn't include anything in regards to this report.

kreezxil commented 4 years ago

I'm not even sure who to report this too. Probably the M&S team. Ok, I reported it.

Tarlin83 commented 4 years ago

Needs crosslink.

AzureDoom commented 4 years ago

I created an issue for this https://github.com/SilentChaos512/Silent-Gear/issues/79 along with the referenced PR above.

Tarlin83 commented 4 years ago

Just checked with the compatibility mod to see if this issue was resolved, and hand crafted blueprint armor is not fixed with the compat. No reply from silent gear as to a resolution yet.

AzureDoom commented 4 years ago

I have not done it in the Compatibility mod as I already opened a PR to the Silent Gear mod to fix the armor so I'd rather not release a mod that will be overridden once the mod it tries to compat updates. I will give the Silent Gear team a week, after that, I will add it to the Compatibility mod.

AzureDoom commented 4 years ago

Talked to SilentChaos512 on their discord, Said they'll try and merge my PR for armor Tuesday/Wednesday.

kreezxil commented 4 years ago

fixed with auto compat

AzureDoom commented 4 years ago

If you are talking about my Auto Compatibility mod, I don't do Silent Gears stuff in it since it's already built in to Silent Gears. Just awaiting my PR to be merged for it to fix the armor.