kreizlie / HP-ProBook-430-G5-Hackintosh

OpenCore setup for running macOS BigSur beta on HP ProBook 430 G5
24 stars 8 forks source link

About Battery Patch 430G5 #8

Closed TzeKitKwok closed 3 years ago

TzeKitKwok commented 3 years ago

Hello, battery patch use a week after the upper right corner of the battery icon appears to suggest repair, the driver is smcbatterymanager, behind each reboot will appear to suggest repair, how to solve?

The attachment shows the contents of 建议维修=Recommended Repair 预设容量=Preset capacity 全负荷容量=Full load capacity

87D51BB6454ACEE1B3E98ECA84609431 1DCA9A78A417AA685F4DB86E4B40707C

kreizlie commented 3 years ago

FIX-BAT

Open your DSDT.dsl, your DSDT has two BTST methods, the long one inside EC0 device and the other one is short like in picture above. Replace short BTST (not EC0 one) method with my BTST method, to recalculate the value needed to have a correct battery status.

TzeKitKwok commented 3 years ago

Okay I know, I have replaced on, still need more than a week to test, I found your SSDT battery missing _BIX method, with this can show the battery health, cycle count, all kinds of information about the battery, I am zhan66G1, I upgraded the latest 1.14BIOS, similar to your DSDT, thank you very much!

kreizlie commented 3 years ago

Thank you for testing my SSDT, I have no idea how to implement _BIX method, can you share the code with me?

On Fri, Feb 19, 2021 at 8:42 PM TzeKit Kwok notifications@github.com wrote:

Okay I know, I have replaced on, still need more than a week to test, I found your SSDT battery missing _BIX method, with this can show the battery health, cycle count, all kinds of information about the battery, I am zhan66G1, I upgraded the latest 1.14BIOS, similar to your DSDT, thank you very much!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kreizlie/HP-ProBook-430-G5-Hackintosh/issues/8#issuecomment-782082781, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6WE2XYDUTSU6ASZEEQJEDS7ZTELANCNFSM4X33IHGQ .

TzeKitKwok commented 3 years ago

Thank you for testing my SSDT, I have no idea how to implement _BIX method, can you share the code with me? On Fri, Feb 19, 2021 at 8:42 PM TzeKit Kwok @.***> wrote: Okay I know, I have replaced on, still need more than a week to test, I found your SSDT battery missing _BIX method, with this can show the battery health, cycle count, all kinds of information about the battery, I am zhan66G1, I upgraded the latest 1.14BIOS, similar to your DSDT, thank you very much! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6WE2XYDUTSU6ASZEEQJEDS7ZTELANCNFSM4X33IHGQ .

You can first update BIOS 1.14 , the new version adds public WMI support to get battery information through third-party software, cloverF4 to extract the original DSDT, search for _BIX and it comes out, then make SSDT battery patch. There may be _BIX even without updating BIOS, you extract DSDT to see if there is one, or you can just use my battery patch. Attached is my EFI and raw DSDT DSDT.dsl.zip EFI.zip

TzeKitKwok commented 3 years ago

Thank you for testing my SSDT, I have no idea how to implement _BIX method, can you share the code with me? On Fri, Feb 19, 2021 at 8:42 PM TzeKit Kwok @.***> wrote: Okay I know, I have replaced on, still need more than a week to test, I found your SSDT battery missing _BIX method, with this can show the battery health, cycle count, all kinds of information about the battery, I am zhan66G1, I upgraded the latest 1.14BIOS, similar to your DSDT, thank you very much! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6WE2XYDUTSU6ASZEEQJEDS7ZTELANCNFSM4X33IHGQ .

Update BIOS1.14 after the battery is not available state, to extract the original DSDT re-make hotpatch

kreizlie commented 3 years ago

Okay friend, that is very interesting, I will find some free time to try that new BIOS version to get the battery advanced information.

kreizlie commented 3 years ago

@TzeKitKwok Do you enable HiDPI? If yes, what resolution work best for you?

TzeKitKwok commented 3 years ago

@TzeKitKwok Do you enable HiDPI? If yes, what resolution work best for you?

My computer screen resolution is 1920x1080 , enable HIDPI 1600x900 1440x810 best for me. I think you need to replace the 1080P screen

TzeKitKwok commented 3 years ago

FIX-BAT

Open your DSDT.dsl, your DSDT has two BTST methods, the long one inside EC0 device and the other one is short like in picture above. Replace short BTST (not EC0 one) method with my BTST method, to recalculate the value needed to have a correct battery status.

Battery according to what you said to do, or not, showing the word recommended for repair, I need you to solve the problem

kreizlie commented 3 years ago

I have upgraded to BIOS 01.14.01, same with yours. I did ACPI dump with CLOVER and remade SSDT-BAT.dsl. New BIOS doesn't has false battery warning issue, so there is no need to replace non-EC BTST method as I mentioned in the picture above. What you have to do is to replace > 8bits registers with multiple 8bit registers, on BTIF, BTIX and BTST methods. The battery status work normal and cycle count appear on system report window. You can checkout the new SSDT-BAT.dsl here https://github.com/kreizlie/HP-ProBook-430-G5-Hackintosh/blob/master/hotpatch/SSDT-BAT.dsl

I hope you can make your own SSDT-BAT.dsl using your ACPI dump, because your ACPI dump may be different from mine.

TzeKitKwok commented 3 years ago

I have upgraded to BIOS 01.14.01, same with yours. I did ACPI dump with CLOVER and remade SSDT-BAT.dsl. New BIOS doesn't has false battery warning issue, so there is no need to replace non-EC BTST method as I mentioned in the picture above. What you have to do is to replace > 8bits registers with multiple 8bit registers, on BTIF, BTIX and BTST methods. The battery status work normal and cycle count appear on system report window. You can checkout the new SSDT-BAT.dsl here https://github.com/kreizlie/HP-ProBook-430-G5-Hackintosh/blob/master/hotpatch/SSDT-BAT.dsl

I hope you can make your own SSDT-BAT.dsl using your ACPI dump, because your ACPI dump may be different from mine.

Ok I got it, thank you

TzeKitKwok commented 3 years ago

@kreizlie Is your computer running Big Sur lagging? Browse complex web pages CPU will not downscale, GPU frequency up CPU downscale, have not encountered

kreizlie commented 3 years ago

I am using HiDPI scaled resolution 1520 x 855 (fake resolution 3040x1710) with no lagging, I am quite satisfied with this machine's performance using this setting. I did experiments with many fake resolutions, and test each performance, I think the higher resolution you set cause slower graphic performance.

TzeKitKwok commented 3 years ago

@kreizlie ok ,Did you set the CPU inverter driver, CPUFriendProvider.kext?

kreizlie commented 3 years ago

Yes, I use CPUFriendFriend to generate SSDT-CPU.aml file, with CPUFriend.kext, not using CPUFriendProvider.kext

TzeKitKwok commented 3 years ago

ok thankyou! @kreizlie

TzeKitKwok commented 3 years ago

I have upgraded to BIOS 01.14.01, same with yours. I did ACPI dump with CLOVER and remade SSDT-BAT.dsl. New BIOS doesn't has false battery warning issue, so there is no need to replace non-EC BTST method as I mentioned in the picture above. What you have to do is to replace > 8bits registers with multiple 8bit registers, on BTIF, BTIX and BTST methods. The battery status work normal and cycle count appear on system report window. You can checkout the new SSDT-BAT.dsl here https://github.com/kreizlie/HP-ProBook-430-G5-Hackintosh/blob/master/hotpatch/SSDT-BAT.dsl

I hope you can make your own SSDT-BAT.dsl using your ACPI dump, because your ACPI dump may be different from mine.

"ITLB" will affect the performance of the CPU, without this part, the CPU will drop to the default frequency TDP power consumption down to 10W or less After adding the CPU TDP power consumption 15W running frequency 2.2Ghz, which is the normal level of i5-8250U. 截屏2021-03-29 上午10 24 08 截屏2021-03-29 上午10 29 18

TzeKitKwok commented 3 years ago

Sorry, I just tested the zhan 66 pro g2 with "ITLB" still down to the default frequency, may not be useful

kreizlie commented 3 years ago

How do you install your CPUFriend? If you use CPUFriendFriend you can choose the lower EPP value, that makes the CPU more responsive and increase the frequency faster, but will not stay on peak frequency and will go lower as the load decrease, I think this is good for a laptop.

TzeKitKwok commented 3 years ago

How do you install your CPUFriend? If you use CPUFriendFriend you can choose the lower EPP value, that makes the CPU more responsive and increase the frequency faster, but will not stay on peak frequency and will go lower as the load decrease, I think this is good for a laptop.

CPU performance issues have been resolved

TzeKitKwok commented 3 years ago

@kreizlie Hi, I would like to ask you how to write the battery patch rename? I got a new machine ProBook440G6

kreizlie commented 3 years ago

What I did was trying to solve any ACPI error that appears in boot log message, I use Hackintool to find an ACPI error message related to battery status issue, usually BTST, BTIF, and create patches exactly for those. Copy the original method mentioned in error messages from my ACPI dump (original one, from Clover) to new SSDT file, replace EC registers larger than 8 bits, use B1B2 method to split them into multiple 8 bits registers.