krescruz / angular-materialize

Angularjs directives for Materialize CSS Framework https://github.com/Dogfalo/materialize
MIT License
397 stars 129 forks source link

Needs more documentation regarding Modals #185

Open echosalik opened 8 years ago

echosalik commented 8 years ago

There is little or no detail on how modal works. Please give more details regarding modals like a code sample etc. Not just HTML markup.

webbiesdk commented 8 years ago

2 things:

Remember, no-one is getting paid to do this.

echosalik commented 8 years ago

Dude, if i was that good with angular I would have submitted a pull request. :P Plus thanks for the direction. I was using developer tools to view the HTML and wasn't able to find it.

echosalik commented 8 years ago

@webbiesdk would you be abel to provide a modal example with controller? All i see is this line in ModalController scope.openModal = false; but I dont get it how to use it. Like where is openModal applied etc.

echosalik commented 8 years ago

Ok, I got it to work. Which is kinda a long route to be honest. You need an extra element for this to work. As you have already labeled it as an enhancement, my suggestion for the enhancement is: Allow modals to be set without this extra element (trigger element).

mushtaqak commented 7 years ago

I agree with @webbiesdk that if we want more documentation then we should need to add some documentation ourselves, this way future developers won't have to waste a lot of times. 👍

vikasraok commented 7 years ago

@DragoTechInnovations put up your solution here maybe? I just went with the ui.bootstrap modal instead.