search

krescruz / angular-materialize

Angularjs directives for Materialize CSS Framework https://github.com/Dogfalo/materialize
MIT License
397 stars 129 forks source link

Modal options updated #221

Closed iqqmuT closed 7 years ago

iqqmuT commented 7 years ago
iqqmuT commented 7 years ago

Updated materialize to 0.98.1, changed options to camelCase.

webbiesdk commented 7 years ago

The string 0.97.8 appears many other places in the repository, what you have done is a very incomplete update to 0.98.1.

Have you tested that the existing directives work with an update to 0.98.1?

I know I might be picky, but an update of Materialize is all or nothing.

iqqmuT commented 7 years ago

It's good to be picky, it maintains the good quality. :) index.html is now updated to use 0.98.1, are there other references to it? I tested with index.html and the directives work well.

webbiesdk commented 7 years ago

I think the only one missing is bower.json

iqqmuT commented 7 years ago

I already updated it: "materialize": "~0.98.1",

webbiesdk commented 7 years ago

Oh, missed it.

I'll do a merge first, test later (it's easier).

webbiesdk commented 7 years ago

Yep, it seems to be working fine.