kreshuklab / plant-seg

A tool for cell instance aware segmentation in densely packed 3D volumetric images
https://kreshuklab.github.io/plant-seg/
MIT License
97 stars 31 forks source link

Move plantseg to conda-forge #176

Closed wolny closed 10 months ago

wolny commented 11 months ago

Here's the conda-forge PR: https://github.com/conda-forge/staged-recipes/pull/24713 @lorenzocerrone @qin-yu could you write in the comments of this PR that you agree to be a maintainer?

wolny commented 11 months ago

for some reason the tests fail for linux build:


  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/napari/utils/colormaps/__init__.py", line 2, in <module>
    from napari.utils.colormaps.colormap import Colormap
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/_pytest/assertion/rewrite.py", line 186, in exec_module
    exec(co, module.__dict__)
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/napari/utils/colormaps/colormap.py", line 7, in <module>
    from napari.utils.color import ColorArray
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/_pytest/assertion/rewrite.py", line 186, in exec_module
    exec(co, module.__dict__)
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/napari/utils/color.py", line 7, in <module>
    from napari.utils.colormaps.standardize_color import transform_color
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/_pytest/assertion/rewrite.py", line 186, in exec_module
    exec(co, module.__dict__)
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/napari/utils/colormaps/standardize_color.py", line 27, in <module>
    from vispy.color import ColorArray, get_color_dict, get_color_names
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/vispy/color/__init__.py", line 12, in <module>
    from .colormap import (Colormap, BaseColormap,  # noqa
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/vispy/color/colormap.py", line 14, in <module>
    import vispy.gloo
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/vispy/gloo/__init__.py", line 47, in <module>
    from . import gl  # noqa
    ^^^^^^^^^^^^^^^^
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/vispy/gloo/gl/__init__.py", line 230, in <module>
    from . import es2 as default_backend  # noqa
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/conda/staged-recipes/build_artifacts/plant-seg_1701963102630/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.11/site-packages/vispy/gloo/gl/es2.py", line 48, in <module>
    raise OSError('GL ES 2.0 library not found')

see: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=838731&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823

I'll add pyqt explicitly to meta.yaml and see if it works

wolny commented 11 months ago

@constantinpape also run into this issue, when trying to release micro-sam (https://github.com/conda-forge/staged-recipes/pull/23374). Looks like the workaround is to remove napari from the dependencies for now...

lorenzocerrone commented 11 months ago

Hey Man, thanks for the PR. Have you tried to use this fix in the first comment? https://github.com/conda-forge/staged-recipes/pull/23374#issuecomment-1649675734

PS: in the PR, should I just write that I will be a maintainer? or is there a specific command?

qin-yu commented 11 months ago

I agree to be a maintainer.

wolny commented 11 months ago

@lorenzocerrone I've added yum_requirements.txt for opengl, let's see if it works

@lorenzocerrone @qin-yu it's enough to say 'I agree to be maintainer/co-maintainer of this package' in the comment of the conda-forge PR https://github.com/conda-forge/staged-recipes/pull/24713

wolny commented 11 months ago

@lorenzocerrone jtlyk, adding yum_requirements solved the issue with opengl. There is a problem with windows build Unsatisfiable dependencies for platform win-64: "pytorch". I'll try to add pytorch as optional dependency, since anyway it has to be installed separately with pytorch and nvidia channels.

wolny commented 11 months ago

kk, all checks have passed, so it's good to go. I've pinged the reviewers.

wolny commented 10 months ago

plant-seg is on conda-forge now! Here's the feedstock repo: https://github.com/conda-forge/plant-seg-feedstock we need to keep up to date with future releases. We should update the installation instructions to use the conda-forge channel now.