PlantSeg pipelines do not reuse code

kreshuklab / plant-seg

A tool for cell instance aware segmentation in densely packed 3D volumetric images

https://kreshuklab.github.io/plant-seg/

MIT License

89 stars 30 forks source link

Open qin-yu opened 3 months ago

qin-yu commented 3 months ago

This adds to the complexity of code. e.g.

UnetPredictions class in /g/kreshuk/yu/repositories/plant-seg-doc/plantseg/predictions/predict.py and
unet_predictions function in /g/kreshuk/yu/repositories/plant-seg-doc/plantseg/predictions/functional/predictions.py

need to be merged for easier maintenance.

qin-yu commented 3 months ago

In these two prediction modules, one is able to use global normalisation while another couldn't. I fixed the later in #220 but overlooked the former.

If there has been a choice between global and patch level normalisation, I should have kept the option.