search

krestenkrab / triq

Trifork QuickCheck
http://krestenkrab.github.com/triq/
Apache License 2.0
281 stars 54 forks source link

19.0 compatibility: introduce and use compat random number module #61

Closed ghost closed 8 years ago

jj1bdx commented 8 years ago

@tuncer rand_compat looks ok, though if no explicit seeding is needed, just use rand:seed(exsplus). See https://github.com/rebar/rebar/pull/612#issuecomment-234956773 for the details. Note: this is not applicable to random:seed/1.

luc-tielen commented 8 years ago

Looks good but CI failed? Or is this just a flaky unit test?

ghost commented 8 years ago

Let's trigger a retest...

ghost commented 8 years ago

@jj1bdx, yeah, that could make sense, but let's get the compat fix in and tackle that later.

ghost commented 8 years ago

@krestenkrab, ping?

alakra commented 8 years ago

👍

nippysaurus commented 8 years ago

LGTM. Only issue if the following error during compilation:

Error evaluating Rebar config script ./rebar.config.script:13: evaluation failed with reason error:{badmatch,{error,{already_started,crypto}}} and stacktrace [{erl_eval,expr,3,[]}]
Any dependencies defined in the script won't be available unless you add them to your Mix project
ghost commented 8 years ago

@nippysaurus, good catch, pushed a fix.

ghost commented 8 years ago

Merged to https://github.com/triqng/triq, closing.