search

kreteshq / kretes

A Programming Environment for TypeScript & Deno
https://kretes.dev/
Other
676 stars 35 forks source link

Use global Node in tasks.json #55

Closed hasparus closed 4 years ago

hasparus commented 4 years ago

tasks.json assumes Node installation directory. Mine is in /usr/bin but I suppose people can use huncwot on Windows.

Is there a problem with stripping /usr/local/bin/ here that I missed?

zaiste commented 4 years ago

@hasparus It's an improvement. Your way is better IMHO. I'm not sure how it works on WIndows. I propose to wait till someone reports such issue.

zaiste commented 4 years ago

@hasparus By the way, what do you think about the following Git message convention ? I should've put this somewhere in README, but I forgot about it ;)

hasparus commented 4 years ago

:man_facepalming: I usually check if there's commitlint config or look at the git log, but I kinda forgot about it.

GitHub supports CONTRIBUTING.md pretty well (I'm not sure but I think it can be placed in .github directory).

Is the only difference between this convention and Conventional Commits that the /context is after slash and (scope) in parentheses?

zaiste commented 4 years ago

I'd be up for that approach. I didn't know about GitHub support for that.

Yes, exactly. It's just a bit less of letters and it looks nicer IMHO. ;) Also, to have it work well, we should together identify possible values for context (kind of an enum) so that later on we could do some stats per context