kreutz-lab / DIMAR

Data-driven selction of an imputation algorithm in R
4 stars 0 forks source link

Add imputation package name to DESCRIPTION #7

Closed aretaon closed 3 months ago

aretaon commented 3 months ago

Hi,

I am automatically building DIMAR with GitHub workflows and therefore rely on pak for installation and dependency solving. With explicitly specifying the remotes in the DESCRIPTION file for DIMAR, my routine broke because pak is not able to infer the package name for the imputation package.

Could you add the relevant package name to your DESCRIPTION (as specified in https://github.com/r-lib/remotes/pull/719) and provide the source for the DMwR package i.e.

Remotes:
    github::cran/DMwR,
    imputation=url::https://cran.r-project.org/src/contrib/Archive/imputation/imputation_1.3.tar.gz

Thanks!

mengerj commented 3 months ago

Hi, this should be implemeted, does remotes::install_github("kreutz-lab/DIMAR") not work for you?

aretaon commented 3 months ago

Hi Jonatan,

I am running my installation through pak (https://github.com/r-lib/pak) as it provides parallel processing for package installation which speeds up the setup of a docker container significantly. However, pak relies on these additional tags that are not present in your DESCRIPTION file (and which also should not interfere with installation through remotes, see above).

For clarity, this is the error I am getting with pak

! Could not solve package dependencies:
* github::kreutz-lab/DIMAR: ! pkgdepends resolution error for github::kreutz-lab/DIMAR.
Caused by error: 
! Cannot determine package name for 1 package:
"url::https://cran.r-project.org/src/contrib/Archive/imputation/imputation_1.3.tar.gz".
ℹ Maybe you need to add a `<packagename>‌=` prefix?
---
Backtrace:
1. pak::pkg_install(package)
2. pak:::remote(function(...) get("pkg_install_make_plan", asNamespace("pak"))(...)…
3. err$throw(res$error)
---

The installation with remotes works fine but I don't want to use a different package installer for every package and I would like to stay with pak.

mengerj commented 3 months ago

I included the tag

aretaon commented 3 months ago

Sorry for the late response and thanks for including the tag. This fixed my problem.