search

kreuzerk / ng-sortgrid

🧐 A grid that allows you to sort all items via drag & drop. Items can be sorted in all directions (↕️ and ↔️). You can also select and sort multiple items at the same time by pressing ctrl and click on the item.
https://kreuzerk.github.io/ng-sortgrid/
MIT License
144 stars 19 forks source link

feat: (draghandle) drag handle implementation #79

Closed Alessy closed 2 years ago

Alessy commented 2 years ago

Drag handle implementation (like cdkDragHandle).
I and a few people wanted this feature, so here it is :) The only problem is that I don't know how to write test scenarios in ngsg-item.directive.spec.ts

kreuzerk commented 2 years ago

Hi @Alessy. Wow. Thx a lot. The changes look good. I left one small comment because of a typo. Would be great if you could fix this typo and then we can merge. Great work 👍

codecov-commenter commented 2 years ago

Codecov Report

Merging #79 (116f3f5) into master (c570433) will decrease coverage by 0.53%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   93.93%   93.40%   -0.54%     
==========================================
  Files           9       10       +1     
  Lines         264      273       +9     
  Branches       25       26       +1     
==========================================
+ Hits          248      255       +7     
- Misses         16       18       +2
Impacted Files Coverage Δ
...rojects/ng-sortgrid/src/lib/ngsg-item.directive.ts 84.33% <71.42%> (-1.38%) :arrow_down:
.../ng-sortgrid/src/lib/ngsg-drag-handle.directive.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c570433...116f3f5. Read the comment docs.

kreuzerk commented 2 years ago

:tada: This PR is included in version 5.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: