search

kreuzwerker / terraform-provider-docker

Terraform Docker provider
Mozilla Public License 2.0
611 stars 187 forks source link

Proposal: Container file upload and docker host behind bastion #18

Open mf-sky opened 3 years ago

mf-sky commented 3 years ago

Hi team.

I have the following feature proposal:

Resource Docker Container

Provider

Thanks for your time!

mavogel commented 3 years ago

Hi Manuel,

sure thing. Thanks for the proposal.

Allow upload of directory would be a major upgrade.

Sounds reasonable

My host is behind a bastion and i can reach it if i have a config file for ssh and reference that connection on the host directive.

Do you mean that the machine the docker host is on, is reachable only via a bastion host? If so I already played around with something like this in the past: https://github.com/hashicorp/terraform-provider-docker/tree/feat/bastion-host-new-dclient

mf-sky commented 3 years ago

Hi Manuel :)

My host is behind a bastion and i can reach it if i have a config file for ssh and reference that connection on the host directive.

Do you mean that the machine the docker host is on, is reachable only via a bastion host? If so I already played around with something like this in the past: https://github.com/hashicorp/terraform-provider-docker/tree/feat/bastion-host-new-dclient

Exactly this! But it's not available officially, is it?

Thanks for the feedback!

mavogel commented 3 years ago

Not yet. There is no plan how to use a terraform provider's endpoint with a jump host in between. But we can implement it here to make a POC. Let me finish #102 and the current milestone, then we can revisit this.

mf-sky commented 3 years ago

Awesome! Thanks @mavogel

innovate-invent commented 3 years ago

You should also consider how this plays in with resource provisioners. Uploading multiple files can also be done with a dynamic "upload" and a list of files created elsewhere.

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. If you don't want this issue to be closed, please set the label pinned.

mf-sky commented 3 years ago

It seems that i cant ghet this one to pinned. Regarding innovate-invent comment, i don't want to maintain a list of files to upload. I simply want to put X files in there and let the provider copy them transparently

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. If you don't want this issue to be closed, please set the label pinned.

innovate-invent commented 3 years ago

It seems that i cant ghet this one to pinned. Regarding innovate-invent comment, i don't want to maintain a list of files to upload. I simply want to put X files in there and let the provider copy them transparently

I didn't necessarily mean that you would manually maintain a list, I meant that the list could be generated elsewhere. See https://www.terraform.io/docs/language/functions/fileset.html