search

krevis / MIDIApps

MIDI apps for Mac OS X: MIDI Monitor and SysEx Librarian.
http://www.snoize.com/
BSD 3-Clause "New" or "Revised" License
714 stars 112 forks source link

Added auto-select midi device feature in response to issue #65 #71

Closed thealienthing closed 5 years ago

thealienthing commented 5 years ago

I added an auto-connect feature to the preferences window in February. It was just an on/off button so if both buttons for auto-connecting in a new window and auto-connecting in a current window were selected, it combined both behaviors. Most recent commits in June changed the UI so that the preferences were chosen using a radio button.

This is my first real pull request to an open source project. Please let me know if I need to change anything. I'm happy to do anything necessary in order to be able to participate in this project. Thank you!

thealienthing commented 5 years ago

Added the uninstall instructions to the documentation.

krevis commented 5 years ago

Hi, thank you for the PR. it has been an exceptionally busy few months for me (iOS 13...) and I'm trying to catch up. Taking a look.

I think the uninstall instructions change (#68) would ideally be a separate PR.

thealienthing commented 5 years ago

I've fixed all the issues you've mentioned and push them to my master branch. Is there anything I need to do on this pull request, or can you see those changes?

krevis commented 5 years ago

Got the rest of the changes, thanks! Will take a look over the holiday this week or the weekend.