search

krey / protonvpn-docker

Setup for running protonvpn inside a docker container
15 stars 7 forks source link

Eliminate credentials from the image #4

Open c01o opened 4 years ago

c01o commented 4 years ago

XXX: Initializations of protonvpn are done on container launching, not on image building. This is because protonvpn saves credentials in plain text format, but consider initializing on build and prune just credentials. To achieve this, we should investigate what protonvpn init generates indeed. Is it safe to remove just credentials and retain the others?

krey commented 3 years ago

Hi c01o

Thanks for the PR and sorry that I'm just getting around to taking a look.

Am I correct in understanding that the purpose of this PR is to remove plaintext password stored in the image? Is this a security measure?

Or I guess I'm confused