search

krfkeith / metacello

Automatically exported from code.google.com/p/metacello
0 stars 0 forks source link

Morphic-based browser needs t ouse OB-style isActive #126

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
I've just gone through list of commands (MetacelloBrowser 1.59 (dkh.257)) and 
defined isActive in terms of whether or not the command applies to the target, 
i.e., can't checkpoint dev if no #development version defined...

Morphic menu builder ought to use isActive as well ...

Original issue reported on code.google.com by henrichs...@gmail.com on 6 Apr 2011 at 11:25

GoogleCodeExporter commented 9 years ago 
Hi Dale!

Can you be a bit more specific on this? isActive is defined on MBCommand and 
heavily overridden. 
Are you referring to the button at the top of the browser?

Original comment by alexandr...@gmail.com on 7 Apr 2011 at 12:37

GoogleCodeExporter commented 9 years ago 
In OB the #isActive method is used to control whether or not buttons are 
activated or whether or not a menu item shows up for the selected target ... 
for example, the 'compare to stable' command is useless if there is no #stable 
version defined, so the isActive logic for that command answers false if there 
is no #stable version defined and the menu item only shows up in projects that 
have a #stable version defined ... there are several other examples ...

The Morphic menus do not use this logic when constructing the menu and they 
probably should ...

Original comment by henrichs...@gmail.com on 7 Apr 2011 at 4:10