krfkeith / metacello

Automatically exported from code.google.com/p/metacello
0 stars 0 forks source link

odd spec passes validation #169

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This spec passes validation, but I don't think it should ... I haven't 
determined what happens when you try to load one of these, but I imagine that 
it might not be pretty:

    <version: '1.0-baseline'>

    spec for: #'common' do: [
        spec blessing: #'baseline'.
        spec repository: 'dictionary://Metacello_Dev_Cycle_Repository'.
        spec package: 'AAA' with: [
                spec requires: #('MetacelloTestConfigurationOfFoo' ). ].
        spec group: 'MetacelloTestConfigurationOfFoo' with: #('MetacelloTestConfigurationOfFoo' ). ].

discovered while writing tests for Issue 5. Here's the test case:

    | expectException issues validationError |
    expectException := false.
    [ 
    MetacelloToolBox
        createBaseline: '1.0-baseline'
        for: self configurationName asString
        repository: 'dictionary://' , self repositoryName asString
        requiredProjects: #()
        packages: #('AAA')
        dependencies: {('AAA' -> #('MetacelloTestConfigurationOfFoo'))}
        groups: {('MetacelloTestConfigurationOfFoo' -> #('MetacelloTestConfigurationOfFoo'))} ]
        on: MetacelloValidationFailure
        do: [ :ex | 
            issues := ex issues.
            expectException := true ].
    self assert: expectException.
    self assert: issues size == 1.
    validationError := issues at: 1.
    self assert: validationError reasonCode == #versionCompositionError.
    self assert: validationError callSite == #validateProject:version:

Original issue reported on code.google.com by henrichs...@gmail.com on 18 Jan 2012 at 10:59

GoogleCodeExporter commented 9 years ago
will look into with https://github.com/dalehenrich/metacello-work/issues/5 ...

Original comment by henrichs...@gmail.com on 19 May 2012 at 9:49