search

krfkeith / metacello

Automatically exported from code.google.com/p/metacello
0 stars 0 forks source link

github zip download failures due to filesystem issues #184

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The zipfile created by the github downloads (/tmp/github.zip) leads to a number 
of problems on our CI machine:
- an existing file 'github.zip' exists but insufficient permissions to 
overwrite it
- concurrent downloads on the same machine were interfering

This is because we are running pharo and gemstone instances on this machine, 
running as different users. A zipfile that was left by Pharo could not be 
overwritten by the load in Gemstone and vice-versa. Furthermore, we have 
multiple builds running concurrently and noticed potential conflicts regarding 
this identical zipfile name.

The failed downloads were correctly reported in Pharo as "GoferRepositoryError: 
Could not delete the old version of file /tmp/github.zip'" but in Gemstone, 
there was only a 'version not found' error that was thrown.

I made a patch to the code that:
- makes the clear error appear in Gemstone too.
- uses a filename based on the github cache key to reduce zipfile name 
conflicts (also applies to curl.err file)
- removes the downloaded file afterwards to prevent permission conflicts

4 patched methods (in Gemstone) attached to this issue.

Original issue reported on code.google.com by johanbri...@gmail.com on 26 Feb 2013 at 10:00

Attachments:

GoogleCodeExporter commented 9 years ago 
commited your suggested bugfix (ported to pharo and squeak) to github:
  https://github.com/dalehenrich/metacello-work/commit/ef0398e89747c9afb951117f9980be141f632cec

will be available in Metacello-Preview 1.0.0-beta.32.8

Original comment by henrichs...@gmail.com on 1 Jul 2013 at 8:39

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 1 Jul 2013 at 8:39