krfkeith / metacello

Automatically exported from code.google.com/p/metacello
0 stars 0 forks source link

later version of Project reference not loaded after old version already loaded #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Seaside30 3.0.0-alpha5.13 
  depends upon Grease 1.0-alpha9.1 and Grease 
    depends upon Refactoring Browser 1.2 #('Refactoring-Core' )
Seaside30 3.0.0-alpha5.13 also
  depends upon OB 1.1.4 and OB
    depends upon Refactoring Browser 1.3 #('Refactoring-Core' )

After all is said and done, I would expect that the packages from 
Refactoring Browser 1.3 #('Refactoring-Core' ) would be loaded in the 
image:

  AST-Core-lr.72
  Refactoring-Core-lr.131

but instead with Metacello 1.0-beta.26.1 the Refactoring Browser 1.2 
#('Refactoring-Core' ) packages are loaded:
  AST-Core-lr.66
  Refactoring-Core-lr.115

Here's the relevant parts from the load directive 
`(ConfigurationOfSeaside30 project version: '3.0.0-alpha5.13') record.`:

    linear load : 3.0.0-alpha5.13 [ConfigurationOfSeaside30]
        linear load : 1.0-alpha9.1 [ConfigurationOfGrease]
            load : ConfigurationOfRefactoringBrowser
        linear load : 1.0-alpha9.1 [ConfigurationOfGrease]
            load : Grease-Core-lr.37
            load : Grease-Pharo-Core-jok.18
            linear load : 1.2 
[ConfigurationOfRefactoringBrowser]
                load : AST-Core-lr.66
                load : Refactoring-Core-lr.115
            load : Grease-Slime-jok.5

  and
        linear load : 1.1.4 [ConfigurationOfOmniBrowser]
            load : OmniBrowser-lr.476
            load : OB-Morphic-lr.122
            load : OB-Standard-lr.468

So it looks as thought when OB 1.1.4 is loaded the fact that version 1.3 of 
Refactoring Browser is not being processed...

In MetacellMCProjectSpec>>loadVersion: the `vrsn packages` are scanned for 
loaded packages and any packages that are loaded outside of the ones called 
for in the #loaded spec are added to the list of packages to be loaded.

However, the projects _are not_ scanned for loaded project refs and this is 
why the project is skipped.

Original issue reported on code.google.com by henrichs...@gmail.com on 14 May 2010 at 11:37

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 14 May 2010 at 11:45

GoogleCodeExporter commented 9 years ago
Here's the proposed fix:

Name: Metacello-MC-dkh.405
Author: dkh
Time: 14 May 2010, 5:04:10 pm
UUID: c15ed7ef-4b6b-4b65-99c5-320dca4c7220
Ancestors: Metacello-MC-DaleHenrichs.404

still need test case before calling this one good...

Original comment by henrichs...@gmail.com on 15 May 2010 at 12:05

GoogleCodeExporter commented 9 years ago
Added a test for this issue 
MetacelloGoferBasedLoaderTest>>testIssue77...validates 
the proposed fix:)

Name: ConfigurationOfMetacello-DaleHenrichs.298
Author: DaleHenrichs
Time: 19 May 2010, 2:31:48 pm
UUID: 4dacabf5-6956-45ee-87a2-b051c6670df0
Ancestors: ConfigurationOfMetacello-DaleHenrichs.297

Original comment by henrichs...@gmail.com on 19 May 2010 at 9:32

GoogleCodeExporter commented 9 years ago
bulk verify

Original comment by henrichs...@gmail.com on 18 Apr 2011 at 5:32