search

krgauthi / Broids

3 stars 2 forks source link

Ship initialization shouldn't be in Entities class #44

Closed dementeddr closed 11 years ago

dementeddr commented 11 years ago

The Entities class should be an abstract class that all entities inherit from. It should NOT have the initialization code for Ship. Is there a reason? Otherwise I'm going to move it to the Ship constructor.

krgauthi commented 11 years ago

there isn't a reason it should be moved

dementeddr commented 11 years ago

Why should the Entities constructor define and create the body for Ship? The ship constructor should do that. If it stays in the Entities constructor, then every entity that calls it will make a new ship body.

krgauthi commented 11 years ago

move it I don't know why it is there.. everything referencing the ship should be moved into the ship

Edit:: It appears that the things needed for ship are already implemented for ship I think all of that can be deleted from entity and it will still work

dementeddr commented 11 years ago

Okay I moved it. There's a bunch of init code in CoreLogic too, but I'm not sure the best way to move that.