krharsh17 / barview-android

A native android UI library that facilitates representation of categorical data in the form of interesting bars!
https://gitter.im/barview-android/community
26 stars 36 forks source link

Replace all inline static occurences of default values for variables with static variables, which have to be defined in a separate interface named Constants #9

Closed krharsh17 closed 4 years ago

krharsh17 commented 4 years ago

For example in such a case

.
.

            if(LABEL_TEXT_COLOR == null)
                LABEL_TEXT_COLOR = "#424242";
            if(VALUE_TEXT_COLOR == null)
.
.

Replace the static string "#424242" with a static string variable declared in a seperate interface by the name Constants

Sourish-Mukherjee commented 4 years ago

So basically we need to create an Interface for defining all the constants and instead use the interface's variable instead of direct constants? #GSSOC20

krharsh17 commented 4 years ago

@Sourish-Mukherjee Yes exactly

rasacharjee commented 4 years ago

I want to take the issue

Sourish-Mukherjee commented 4 years ago

Will be a good experience for me, I want to take the issue

krharsh17 commented 4 years ago

I'll assign this to @Sourish-Mukherjee as #7 is already assigned to @rasacharjee