kria / TfsNotificationRelay

An extensible plugin for TFS that sends notifications to Slack, HipChat and IRC
GNU General Public License v3.0
116 stars 32 forks source link

TFS 2015.1 notification Not after vNext Builds, only after XAML #37

Closed StanleyOK closed 8 years ago

StanleyOK commented 8 years ago

Thank you for developing TfsNotificationRelay – very interesting tool for TFS, but I there's problem with vNext builds. I’ve installed TfsNotificationRelay v1.15.0 on TFS 2015.1. but it sends post on Slack only after XAML builds After vNext build: no post on Slack and error in Event Viewer:

TF53010: The following error has occurred in a Team Foundation component or extension: . . . Detailed Message: TfsNotificationRelay: Notify failed for bot slack5. Exception Stack Trace: at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at DevCore.TfsNotificationRelay.Slack.SlackNotifier.<>c.<NotifyAsync>b__0_0(Task1 t) . . . Exception Message: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond …:… (type SocketException) . . . Full error from Event Log: VNext_Slack_ERROR.txt My system: TFS server: Windows Server 2012 R2 Standard, TFS 2015 14.0.24712.0 (Tfs2015.Update1); SQL Server 2014 (64-bit) Build machines: Windows Server 2008 R2 Standard, TFS 2012 Up. 2

What's your guess - why it works for XAML builds only ?

kria commented 8 years ago

I would guess that you have changed the url in the config file since restarting Visual Studio Team Foundation Background Job Agent. The config changes are picked up automatically by the standard plugin in Application Tier\Web Services\bin\Plugins, but that is not the case for the plugin in Application Tier\TFSJobAgent\Plugins (which handles vNext builds). So restart the TfsJobAgent.

StanleyOK commented 8 years ago
  1. Thanks for your response. I didn't change url (webhookUrl ?) in these configs - will restart TfsJobAgent just in case. Configs In Application Tier\Web Services\bin\Plugins and in Application Tier\TFSJobAgent\Plugins have the same url value (webhookUrl). Maybe these values shouldn't be equal ?
  2. My 1st guess was: problem with proxy server. But proxy is no problem for XAML builds, is it possible that it would be problem for vNext builds ?
kria commented 8 years ago
  1. You actually only need one config file. If there is no config in Application Tier\TFSJobAgent\Plugins, it will be read from Application Tier\Web Services\bin\Plugins.
  2. Are you using a proxy? I don't think the plugin will auto-detect proxy settings. For it to use a proxy, you need to have a <defaultproxy> in Application Tier\Web Services\web.config and Application Tier\TFSJobAgent\TfsJobAgent.exe.config (for vNext builds).
StanleyOK commented 8 years ago

It works now after I added <defaultproxy> to TfsJobAgent.exe.config, thank you.

kria commented 8 years ago

Glad to hear it!