search

kriansa / fuel-less

Less implementation for FuelPHP using lessphp and nodejs. Unmaintained.
MIT License
28 stars 7 forks source link

Adds support for Michal Moravec's iLess (https://github.com/mishal/iless... #8

Closed pwolfert closed 6 years ago

pwolfert commented 10 years ago

Neither Less.js nor LessPHP will compile the latest Twitter Bootstrap because of the '&:extend(.foo all);' syntax, so I found a PHP compiler that does and added support for it.

kriansa commented 10 years ago

Why Lessjs doesn't compile it, since it's the official implementation? Doesn't make sense to me.

pwolfert commented 10 years ago

According to less/less.js#1177, they seem to have come to a consensus but haven't implemented it yet.

Okay, update: I just put the version of Less.js that shipped with Bootstrap in your lessjs directory, and it seems to compile with your Node parser. That will work for now. I went with the iLess parser originally because I was afraid it would be blocking me on this project for an indeterminate amount of time.

kriansa commented 10 years ago

So it looks like Bootstrap created a fork of Less.js? Seems reasonable to add it as a new driver, what do you think?

pwolfert commented 10 years ago

Well, now that I'm looking at it closer, I see that Bootstrap didn't fork it, that they're using the latest version (1.7.3) in grunt-contrib-less. So, my bad, it does work, but your submodule version is out-of-date, or I'm doing something wrong.

But in any case my driver is unnecessary unless people are looking for a PHP parser that's more up-to-date.

kriansa commented 10 years ago

Oh, in fact, the submodules are way too old. I will update them!

I have to tell you that there's like 3 or more PHP less compilers out there, but none of them makes me willing to support them. I guess that we could just support the official one and it would be just fine.