search

kriansa / h2p

H2P - Convert HTML to PDF using PHP and PhantomJS. Unmaintained.
https://garajau.com.br/projects/h2p-convert-html-files-to-pdf/
75 stars 35 forks source link

Support for more configuration parameters #5

Closed F21 closed 11 years ago

F21 commented 11 years ago

I would like to add zoom and margin and footer and header support.

We can of course, keep adding parameters to __construct() in converter, but pretty soon, we will end up in argument hell.

What do you think about reworking the constructor, so that all arguments will be passed in as an element in an associative array?

We can then convert the associative array to json and passed it to converter.js.

kriansa commented 11 years ago

Features added in wip-2.0 branch.