kriasoft / hyperapp-render

Render Hyperapp to an HTML string with SSR and Node.js streaming support.
MIT License
103 stars 15 forks source link

Broken support for ^2.0.9 #22

Closed BRA1L0R closed 3 years ago

BRA1L0R commented 3 years ago

I'm submitting a ...

Description of the bug

hyperapp-render will not work with anything newer than 2.0.9 (included). This is because the creator of hyperapp made a commit where he switched the name of two keys in the vdom object, see commit 8e6a4908954186ed8466ae9ef15ec172ddbea2d0.

Steps to reproduce

import { renderToString } from 'hyperapp-render'
import { h, text } from 'hyperapp'

console.log(renderToString(h("p", {}, text("Hello World!")))) // output: undefined

With version 2.0.9 the output is: undefined

Expected output

With version 2.0.8 the output of the snippet in the section above is: <p>Hello World!</p>

frenzzy commented 3 years ago

Thank you for the bug report! Just released v4.0.0 :tada: with support for Hyperapp v2.0.9. Demo: CodePen

BRA1L0R commented 3 years ago

Wow how fast