search

kriasoft / isomorphic-style-loader

CSS style loader for Webpack that is optimized for isomorphic (universal) web apps.
https://reactstarter.com
MIT License
1.27k stars 144 forks source link

adds streamable feature to the library #166

Open ImanMh opened 5 years ago

ImanMh commented 5 years ago

Hi there. I've been working on this feature to make it possible to stream SSR react projects made with isomorphic-style-loader. Even though this is not backward compatible I sent you the initial modifications so that we can discuss on what I'm doing here. With this implementation the only change that you need to make to the code is this: 

<StyleContext.Provider value={{ insertCss, css, isServer: true }}>
  <ClientRoot manifest={manifest} />
</StyleContext.Provider>

Users of this library must pass the CSS set and a flag that shows if this code is running on server or not (which can be detected by default if not provided but passing CSS set is mandatory). Before I go ahead and add tests for this feature let me know your thoughts. If you merge this we can have corresponding improvements on react-starter-kit as well.

ImanMh commented 5 years ago

this will fix #164

ImanMh commented 5 years ago

@frenzzy could you please check this out?

frenzzy commented 5 years ago

@ImanMh sorry, I am not interested in maintenance isomorphic-style-loader anymore since I switched to using Emotion (this feature is already there)

@koistya maybe deprecate this project in favor of something else or add a bold message to the readme about searching new maintainers?