kriasoft / react-starter-kit

The web's most popular Jamstack front-end template (boilerplate) for building web applications with React
https://reactstarter.com
MIT License
22.69k stars 4.16k forks source link

refactor: Improvements to Router TypeScript definitions #1966

Closed koistya closed 2 years ago

koistya commented 2 years ago
// BEFORE
import { type Route } from "../core";
import Profile from "./Profile";
import { type ProfileQuery$data } from "../queries/ProfileQuery.graphql"; 

// Route for https://example.com/username
export default {
  route: "/:username",
  query: graphql`...`,
  response(data) { ... }
} as Route<typeof Profile, ProfileQuery$data>;
// AFTER
import { type Route } from "../core";
import { type Profile } from "./Profile";
import { type ProfileQuery } from "../queries/ProfileQuery.graphql"; 

// Route for https://example.com/username
export default {
  route: "/:username",
  query: graphql`...`,
  response(data) { ... }
} as Route<Profile, ProfileQuery>;