kriasoft / universal-router

A simple middleware-style router for isomorphic JavaScript web apps
https://www.kriasoft.com/universal-router/
MIT License
1.7k stars 105 forks source link

Remove unused `params` param in resolveRedirect example #207

Closed sgpinkus closed 2 years ago

sgpinkus commented 2 years ago

Why is it there? The docs say params is part of context object. In any case it is unused in the example.

Types of changes

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #207 (f4cbd6c) into main (ea82159) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          229       229           
  Branches        66        66           
=========================================
  Hits           229       229           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea82159...f4cbd6c. Read the comment docs.

frenzzy commented 2 years ago

Thank you!