kriasoft / universal-router

A simple middleware-style router for isomorphic JavaScript web apps
https://www.kriasoft.com/universal-router/
MIT License
1.7k stars 105 forks source link

Bump TypeScript to 4.9.5, fix types and build #215

Closed mastahdocent closed 1 year ago

mastahdocent commented 1 year ago

Currently universal-router breaks projects that use TypeScript 4.8 and greater. This PR fixes these issues.

mastahdocent commented 1 year ago

@koistya thanks for letting this run, I fixed package-lock.json and it should work fine now :) Hope we can merge this soon :)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8ebdd25) 100.00% compared to head (e17a823) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 3 3 Lines 229 229 Branches 66 66 ========================================= Hits 229 229 ``` | [Impacted Files](https://app.codecov.io/gh/kriasoft/universal-router/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kriasoft) | Coverage Δ | | |---|---|---| | [src/UniversalRouter.ts](https://app.codecov.io/gh/kriasoft/universal-router/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kriasoft#diff-c3JjL1VuaXZlcnNhbFJvdXRlci50cw==) | `100.00% <ø> (ø)` | | | [src/UniversalRouterSync.ts](https://app.codecov.io/gh/kriasoft/universal-router/pull/215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kriasoft#diff-c3JjL1VuaXZlcnNhbFJvdXRlclN5bmMudHM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mastahdocent commented 1 year ago

Hi, any chance for release to NPM? :) Thanks!

koistya commented 1 year ago

@mastahdocent done, thank you!