KOI should first try to terminate a service with SIGTERM

krig / koi

Cluster management software.

ISC License

10 stars 9 forks source link

KOI should first try to terminate a service with SIGTERM #10

Closed abhayyb closed 5 years ago

abhayyb commented 5 years ago

before a SIGKILL. This will help the child process to handle the SIGTERM and clean up stale files and terminate their child processes.

krig commented 5 years ago

Sure, looks good to me.

krig commented 5 years ago

Hmm. I guess the only thing would be the hardcoded 1000*1000 timeouts. At least making it a constant so that it doesn't have to be updated in multiple places would make sense.

abhayyb commented 5 years ago

Made the changes as per review comments.