krig / koi

Cluster management software.
ISC License
10 stars 9 forks source link

Bashisms in scripts #14

Open dmuhamedagic opened 1 year ago

dmuhamedagic commented 1 year ago

In the liveness script, which is quite properly a POSIX shell one, there are a number of bashisms. I'll see if I can make a PR. @krig This is fantastic! Does it work? Do you have good logging? If so, I am going to use it for my new project. Thanks man!

krig commented 1 year ago

Hi! Oh, I haven't updated this project in ages so who knows if it is still viable :D But as far as I know it is still being used in production in at least one place.

I'm sure it's full of bashisms, any fixes you have are more than welcome!

dmuhamedagic commented 1 year ago

Hey Kristoffer, if the project is still somewhere in production then it must be viable for me too! Many thanks for creating this! I think you saved my life, not to have to deal with the huge thing that Pacemaker has become. As for bashisms, yes, there will be something soonish, but my Linux computers are sort of out of order (a Thinkpad laptop with a flaky battery) and I find it difficult to deal with it on my MacBook Air. Cheers, Dejan P.S. How is life in general, let’s talk, I can contact you on WhatsApp if that’s OK with you!

On 13 Sep 2023, at 11:20, Kristoffer Grönlund @.***> wrote:

Hi! Oh, I haven't updated this project in ages so who knows if it is still viable :D But as far as I know it is still being used in production in at least one place.

I'm sure it's full of bashisms, any fixes you have are more than welcome!

— Reply to this email directly, view it on GitHub https://github.com/krig/koi/issues/14#issuecomment-1717262016, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE323SEKLQRVLZGEZ73CCTX2F3EDANCNFSM6AAAAAA4THQUGA. You are receiving this because you authored the thread.

krig commented 1 year ago

Sounds good, no hurries or expectations from my side! Happy to take patches when or if they appear :)

P.S. How is life in general, let’s talk, I can contact you on WhatsApp if that’s OK with you!

Please do! Life is hectic, our baby just turned one, but it's great all the same :)