search

krijnsent / crypto_vba

An Excel/VBA project to communicate with various cryptocurrency exchanges APIs
MIT License
155 stars 54 forks source link

Cannot get Binance and Coinbase Pro to work in example sheet #86

Open kbfifi opened 2 years ago

kbfifi commented 2 years ago

Hello Koen,

Great project! I tried the example sheet and created API keys for Binance and CoinbasePro.

Question: I still do not understand the sheets: How do they get triggered? What causes the sheet content to be updated? I clearly miss the point.

Issue 1: So I tried the corresponding test functions: Ran TestBinance with F5: -Test.IsOk JsonResult("balances").Count > 10, "test Private GET 1g failed, result: ${1}" results in "Run time error 424, object required"

Issue 2: Ran TestCoinbasePro with F5: -Test.IsEqual JsonResult(1)("currency"), "BAT" results in "Run time error 13, Type mismatch"

Any suggestions? Really like it to work. I'm using Office Professional Plus 2016.

kbfifi commented 2 years ago

Ok, spent a little more time on this and got the example sheets for Binance and Coinbase Pro to work. The Binance example code in the sheet is outdated and not in sync with the test function. "account" = > "/api/v3/account"

Besides that I think if the examples would contain a button that triggers the example code it would be more self-explanatory.

krijnsent commented 2 years ago

Hi @kbfifi , thanks for your feedback. I have considered builing a more full fledged tool with buttons etc, but decided in the end to just provide the basic building blocks. So yeah, my code is for some more experienced VBA users and I'm glad you're now one of them ;-). Secondly: I know I should update my exchanges, some are a bit outdated now, but my startup is taking up all my time and I'm not a trader myself, so don't use my own code that much. Cheers, Koen