Some files were not encoded using UTF-8 format, the emulator doesn't compile on Asian versions of Windows

krikic / nulldc

Automatically exported from code.google.com/p/nulldc

0 stars 0 forks source link

Some files were not encoded using UTF-8 format, the emulator doesn't compile on Asian versions of Windows #217

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?

1: Compile the emulator on an Asian version of Windows.

What is the expected output? What do you see instead?
The source code is not interpreted correctly by the compiler.

What version of the product are you using? What build? What plugins?
- Visual Studio 10 (trial).
- Latest sources from SVN.

Operating System: Taiwanese Windows, English language version.

Original issue reported on code.google.com by le.mouli...@gmail.com on 5 Sep 2010 at 5:10

Attachments:

vincent.cantin-nullDC.diff

GoogleCodeExporter commented 9 years ago

This zip file contains the files to update:

nulldc/nullDC/dc/sh4/sh4_opcode_list.cpp
nulldc/nullDC/dc/sh4/tmu.cpp
nulldc/plugins/PuruPuru/PuruPuru.cpp
nulldc/plugins/PuruPuru/PuruPuru.h
nulldc/plugins/PuruPuru/config.cpp
nulldc/plugins/PuruPuru/config.h
nulldc/plugins/nullAICA/mem.cpp
nulldc/plugins/nullExtDev/modem.cpp
nulldc/plugins/vbaARM/mem.cpp

Please give me the commit access, to copy files by hand is kind of painful.

Original comment by le.mouli...@gmail.com on 5 Sep 2010 at 5:32

Attachments:

[patch nullDC.zip](https://storage.googleapis.com/google-code-attachments/nulldc/issue-217/comment-1/patch nullDC.zip)

GoogleCodeExporter commented 9 years ago

make a patch.

Original comment by danialho...@gmail.com on 5 Sep 2010 at 2:59

GoogleCodeExporter commented 9 years ago

Not quite sure a diff/patch can store the utf diffs. @ le.moulin.studio: will 
look it later on after i'm finished sorting up the stuff, just moved houses :)

Original comment by drkIIRaziel on 5 Sep 2010 at 3:08

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

patches and subversion(or similar) apps support UTF and unicode as long as the 
OS does.

Original comment by danialho...@gmail.com on 5 Sep 2010 at 7:35

GoogleCodeExporter commented 9 years ago

It is a little hard for me to make a patch, I am using a different client 
(Mercurial). However, I know that I can commit, so if someone can give me the 
commit access, we would have to waste our time doing it manually.

Original comment by le.mouli...@gmail.com on 5 Sep 2010 at 8:50

GoogleCodeExporter commented 9 years ago

Fixed by r67, or so it seems.

Original comment by KrossX3 on 10 Sep 2010 at 6:00

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

The line 18 of PuruPuru still contains characters not recognized on asian 
windows.

Original comment by le.mouli...@gmail.com on 3 Nov 2010 at 6:08

Changed state: ReOpened