krille-chan / fluffychat

The cutest instant messenger in the [matrix]
https://fluffychat.im/
GNU Affero General Public License v3.0
1.22k stars 222 forks source link

feat[UP]: Notifications for multiple accounts #1389

Closed baltevl closed 1 month ago

baltevl commented 1 month ago

!!This is a WIP!! Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

Pull Request has been tested on:

I started work on supporting notifications on multiple accounts via UP. I succeeded in creating multiple topics (ntfy) but sadly all of them receive notifications only from the same account and that account only. After a bit of digging it seems like flutter_local_notifications works with singletons as our code did before this PR as well. I suspect this leads to the odd behavior. Now I have a few questions on how to proceed: Is there a general interest in this feature? Implementing this feature could required either implementing support upstream or looking for alternatives. Are there opinions in either direction? Are my suspicions right in the first place? Am I overlooking something? Is something else causing this behavior I'm not aware of?

Kind regards :)

baltevl commented 1 month ago

ping @krille-chan. Sry, not sure if Github notifies you about draft prs and I want to get your opinion as maintainer although I'm also eager to her other opinions as well :D

baltevl commented 1 month ago

No worries. I honestly didn't expect you to merge anything, as it doesn't quite work anyways. It was partly for me to get familiar with flutter/dart/fluffychat and partly to just get started and see if I could get something to work. I'll close this PR then. Is there a general interest in me working on this?