fix: inefficient ui flow of scan qr

krille-chan / fluffychat

The cutest instant messenger in the [matrix]

https://fluffychat.im/

GNU Affero General Public License v3.0

1.22k stars 222 forks source link

fix: inefficient ui flow of scan qr #1461

Open Dhruv80576 opened 2 weeks ago

Dhruv80576 commented 2 weeks ago

fix #1453 UI flow for handling Scanqr popup has been handled and for that i used willPopscope ,when back is pressed popup will be closed.

Pull Request has been tested on:

[x] Android
[x] iOS
[ ] Browser (Chromium based)
[ ] Browser (Firefox based)
[ ] Browser (WebKit based)
[ ] Desktop Linux
[ ] Desktop Windows
[ ] Desktop macOS

krille-chan commented 2 weeks ago

@Dhruv80576 thanks for your contribution. It looks like you have implemented a deprecated widget:

info • 'WillPopScope' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre • lib/pages/new_private_chat/new_private_chat.dart:86:23 • deprecated_member_use

Dhruv80576 commented 2 weeks ago

Ohh i will update it

Dhruv80576 commented 2 weeks ago

@krille-chan
i have updated it

Dhruv80576 commented 1 week ago

@krille-chan Can u review it?

krille-chan commented 4 days ago

@Dhruv80576 Can you please squash your commits to one and sign it? Otherwise this cannot be merged

krille-chan commented 3 days ago

@Dhruv80576 the Pull Request still has six commits. Can you squash then please to one?