krille-chan / fluffychat

The cutest instant messenger in the [matrix]
https://fluffychat.im/
GNU Affero General Public License v3.0
1.22k stars 222 forks source link

fix: dont use thumbnails for emoticons #1488

Closed marekvospel closed 1 day ago

marekvospel commented 4 days ago

In this pull request I went over places where MxcImage is used and in case of custom emojis set isThumbnail to false, as the thumbnail generation causes emoticons to lose transparency and in some cases overall animations. (more info in #1071)

The only place I'm worried about is html_message.dart, where I'm using the following snippet: isThumbnail: (actualWidth * actualHeight) > (256 * 256). Maybe using something the data-mx-emoticon property would be more fitting?

Fixes #1071

Pull Request has been tested on:

krille-chan commented 1 day ago

@marekvospel looks good to me :) thank you very much for your contribution. It looks like your commit is not correctly signed yet. Can you sign your commit? According to the policy only signed commits can go into the main branch. More info on that you can find here: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

marekvospel commented 1 day ago

@marekvospel looks good to me :) thank you very much for your contribution. It looks like your commit is not correctly signed yet. Can you sign your commit? According to the policy only signed commits can go into the main branch. More info on that you can find here: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Will do, I just forgot the -S flag. 😅