search

krille-chan / fluffychat

The cutest instant messenger in the [matrix]
https://fluffychat.im/
GNU Affero General Public License v3.0
907 stars 153 forks source link

F-Droid can't build #908

Closed licaon-kter closed 4 months ago

licaon-kter commented 4 months ago

...as core-google-shortcuts is not FOSS since it depends on proprietary Google libs

ref: https://github.com/krille-chan/fluffychat/commit/dee9323d4749b7b5778ada8ab1fcbf07f8f51936#diff-8b7e9df87668ffa6a04b32e1769a33434999e54ae081c52e5d943c541d4c0d25R50

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/373888c541b54a5b77f1abf6f7c0133bf52cab15

linsui commented 4 months ago

I thought we can remove it directly with a sed?

licaon-kter commented 4 months ago

Maybe we can, maybe we can't :) not sure what happens when we remove core-google-shortcuts

will test locally I guess...

imho we might need to revert https://github.com/krille-chan/fluffychat/commit/dee9323d4749b7b5778ada8ab1fcbf07f8f51936#diff-8b7e9df87668ffa6a04b32e1769a33434999e54ae081c52e5d943c541d4c0d25R50 in whole

licaon-kter commented 4 months ago

great https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14601/diffs