Fix send on enter - Githubissues

krille-chan / fluffychat

The cutest instant messenger in the [matrix]

https://fluffychat.im/

GNU Affero General Public License v3.0

907 stars 153 forks source link

Fix send on enter #920

Closed BhasherBEL closed 1 month ago

BhasherBEL commented 4 months ago

This PR aims to fix the fact that send on enter is not working as expected at least on desktop. The issue seems to come from the fact that the settings is null by default, but turned on in the settings.

By providing a default value, this issue should be prevented.

krille-chan commented 4 months ago

Sorry, this does not work. There are three states of the config "sendOnEnter":

true: It should aways send on enter (purpose is to make it possible on mobile as well, so iPad users with keyboard are happy)
false: It should never send on enter (purpose is to make it possible on desktop/web as well, so mobile web users and linux phone users are happy)
null: It fallbacks to the platform, so acts like false on Android&iOS and like true on web&Desktop

We need all three states here to fulfill this

BhasherBEL commented 4 months ago

The null value make it strange, at least for desktop. The displayed state in settings doesn't match the actual behavior.

krille-chan commented 4 months ago

The null value make it strange, at least for desktop. The displayed state in settings doesn't match the actual behavior.

It doesn't make it strange at all. null means here default and the default depends on the platform

github-actions[bot] commented 1 month ago

This pull request was closed because it has been inactive for 14 days since being marked as stale.