krille-chan / fluffychat

The cutest instant messenger in the [matrix]
https://fluffychat.im/
GNU Affero General Public License v3.0
907 stars 153 forks source link

Switch nginx to one that doesn't need root #924

Open halkeye opened 4 months ago

halkeye commented 4 months ago

I prefer running unprivledged containers whenever possible. It seems like an easy win to run as non root.

That being said, if it works, it would be a breaking change since its port 8080 not 80 now

halkeye commented 4 months ago

Confirmed:

deployed @ https://fluffychat.g4v.dev/ config: https://github.com/halkeye/home-k8s/blob/main/charts/fluffychat/values.yaml#L7

krille-chan commented 3 months ago

I don't know if all consumers of the docker image prefer this 🤔 so no idea what to do with it. Can you maybe host this by yourself?

halkeye commented 3 months ago

Yea I can't say either. I generally think rootless docker images are good practice.

I believe I have a docker image created whenever a new release happens, so I'm not desperate, but being lazy it's nicer upstream :)