search

krille-chan / fluffychat

The cutest instant messenger in the [matrix]
https://fluffychat.im/
GNU Affero General Public License v3.0
899 stars 151 forks source link

chore: do not use static openssl #969

Closed Decodetalkers closed 3 months ago

Decodetalkers commented 3 months ago

I close this option, to make it compilable on archlinux.

see the readme https://github.com/simolus3/sqlite3.dart/blob/main/sqlcipher_flutter_libs/README.md

I do not think the option is needed on linux machine

Decodetalkers commented 3 months ago

Emm. useless

Decodetalkers commented 3 months ago

haa. the package need to be updated

Decodetalkers commented 3 months ago

@krille-chan emm. can you help review this pr? thanks very much

TheOneWithTheBraid commented 3 months ago

I close this option, to make it compilable on archlinux.

We have an upstream patch in the AUR package btw 😇 ... But I agree, we should definitely enable this. I will quickly test the snap version, tho I think It should properly work. OpenSSL is already included into the snap.

TheOneWithTheBraid commented 3 months ago

After fighting snapd on Arch Linux for half an hour, I can confirm that the snap still builds, runs and can open close and reopen the database.

@krille-chan I'd propose to merge it, LGTM.

krille-chan commented 3 months ago

After fighting snapd on Arch Linux for half an hour, I can confirm that the snap still builds, runs and can open close and reopen the database.

@krille-chan I'd propose to merge it, LGTM.

Thats great! Thank you very much 💚

TheOneWithTheBraid commented 3 months ago

@krille-chan Can you merge ?

krille-chan commented 3 months ago

@Decodetalkers PR is ready to merge. Is it possible for you to sign your commit?

Decodetalkers commented 3 months ago

@Decodetalkers PR is ready to merge. Is it possible for you to sign your commit?

how to sign it? Emm

Decodetalkers commented 3 months ago

Ok, I have signed it @krille-chan