search

krime / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

typo in PrintAvailability source code #676

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
PrintAvailability should print description and availability, current 
implementation is:

static void PrintAvailability(BOOL var, const char *description) {
  printf("s: %s\n", description, (var ? "Available" : "Not available"));
}

1st parameter of printf has typo in it: "s: %s\n" should be "%s: %s\n"

Original issue reported on code.google.com by ssubbo...@gmail.com on 19 Mar 2015 at 1:33

GoogleCodeExporter commented 9 years ago 
Indeed. Thanks for spotting it. I'm going to give you opportunity to submit a 
patch for it.

Original comment by alkondratenko on 21 Mar 2015 at 6:46

GoogleCodeExporter commented 9 years ago 
Didn't have a lot of experience with git, but a patch file is attached.

Original comment by ssubbo...@gmail.com on 9 Apr 2015 at 8:02

Attachments:

GoogleCodeExporter commented 9 years ago 
Applied. Thanks.

BTW easiest way to submit git patches is something like this:

* git commit -a -v

* review your patch and write good commit message

* git format-patch HEAD^ (which will produce something like 
0001-fix-typo-in-PrintAvailability-code.patch)

* those *patch files have both diff _and_ authorship & commit message. So send 
them and the other end may simply do git am *patch to get not just code change 
but all nice metadata too

Original comment by alkondratenko on 11 Apr 2015 at 6:41