build fails with pre-1.0 APR because of call of apr_socket_create with 5 arguments

[GoogleCodeExporter]

What steps will reproduce the problem?
try to build with version of APR < 1.0

excerpt from configure:

configure: Apache Portable Runtime (APR) library configuration
checking for APR... yes
checking APR version... 0.9.17
configure: Apache Portable Runtime Utility (APRUTIL) library configuration
checking for APR-util... yes
checking APR-UTIL version... 0.9.15

build stops with:

incoming.c: In function 'serf_listener_create':
incoming.c:144: warning: passing argument 4 of 'apr_socket_create' makes pointer
 from integer without a cast
incoming.c:144: error: too many arguments to function 'apr_socket_create'

What version of the product are you using? On what operating system?
serf 0.7.2 on Linux 

Please provide any additional information below.
The problem is still present in trunk. The call of
apr_socket_create must pass different arguments depending on
APR_MAJOR_VERSION (see the call of apr_socket_create in outgoing.c)

Cheers, Roderich

Original issue reported on code.google.com by roderich...@gmail.com on 8 Jul 2011 at 8:43

[GoogleCodeExporter]

Is this really a problem? Why can't APR 1.x be used instead?

Original comment by gstein on 12 Jul 2011 at 11:49

• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Corporate environment - APR is out of my "jurisdiction".

Original comment by roderich...@gmail.com on 13 Jul 2011 at 6:20

[GoogleCodeExporter]

Okay. Suspected something like that. Thanks for the clarification.

This shouldn't be a big deal, so we can quick drop it in for the 1.0 release 
(happening in the next day or two).

Original comment by gstein on 13 Jul 2011 at 6:34

[GoogleCodeExporter]

Fixed in r1533. Thanks!

Original comment by gstein on 13 Jul 2011 at 10:47

• Changed state: Fixed